-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DocumentCardPreview): add name as image alt #27196
base: master
Are you sure you want to change the base?
fix(DocumentCardPreview): add name as image alt #27196
Conversation
📊 Bundle size report🤖 This report was generated against 71da113c01b7de859e440ecd32764bc127bb0ba4 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d08dba1:
|
Asset size changes
Baseline commit: 71da113c01b7de859e440ecd32764bc127bb0ba4 (build) |
@PieterHeemeryck please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
🕵 fluentuiv8 No visual regressions between this PR and main |
@microsoft-github-policy-service agree company="Delaware Consulting CVBA" |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 1565 | 1581 | 5000 | |
Breadcrumb | mount | 3702 | 3757 | 1000 | |
Checkbox | mount | 3429 | 3398 | 5000 | |
CheckboxBase | mount | 3019 | 3025 | 5000 | |
ChoiceGroup | mount | 5803 | 5847 | 5000 | |
ComboBox | mount | 1602 | 1577 | 1000 | |
CommandBar | mount | 12219 | 12058 | 1000 | |
ContextualMenu | mount | 18440 | 18197 | 1000 | |
DefaultButton | mount | 1811 | 1846 | 5000 | |
DetailsRow | mount | 4484 | 4552 | 5000 | |
DetailsRowFast | mount | 4534 | 4545 | 5000 | |
DetailsRowNoStyles | mount | 4275 | 4363 | 5000 | |
Dialog | mount | 3950 | 3907 | 1000 | |
DocumentCardTitle | mount | 719 | 745 | 1000 | |
Dropdown | mount | 4214 | 4297 | 5000 | |
FocusTrapZone | mount | 2504 | 2559 | 5000 | |
FocusZone | mount | 2444 | 2499 | 5000 | |
GroupedList | mount | 67659 | 76907 | 2 | |
GroupedList | virtual-rerender | 31840 | 31960 | 2 | |
GroupedList | virtual-rerender-with-unmount | 108990 | 109668 | 2 | |
GroupedListV2 | mount | 715 | 700 | 2 | |
GroupedListV2 | virtual-rerender | 672 | 659 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 688 | 706 | 2 | |
IconButton | mount | 2514 | 2540 | 5000 | |
Label | mount | 900 | 921 | 5000 | |
Layer | mount | 5507 | 5535 | 5000 | |
Link | mount | 1061 | 1076 | 5000 | |
MenuButton | mount | 2217 | 2174 | 5000 | |
MessageBar | mount | 2873 | 2912 | 5000 | |
Nav | mount | 4218 | 4273 | 1000 | |
OverflowSet | mount | 1715 | 1740 | 5000 | |
Panel | mount | 3091 | 3150 | 1000 | |
Persona | mount | 1660 | 1703 | 1000 | |
Pivot | mount | 2092 | 2135 | 1000 | |
PrimaryButton | mount | 1946 | 1959 | 5000 | |
Rating | mount | 9290 | 9276 | 5000 | |
SearchBox | mount | 1984 | 1998 | 5000 | |
Shimmer | mount | 3744 | 3707 | 5000 | |
Slider | mount | 2694 | 2718 | 5000 | |
SpinButton | mount | 5933 | 5996 | 5000 | |
Spinner | mount | 972 | 986 | 5000 | |
SplitButton | mount | 4029 | 4010 | 5000 | |
Stack | mount | 1048 | 1054 | 5000 | |
StackWithIntrinsicChildren | mount | 3119 | 3175 | 5000 | |
StackWithTextChildren | mount | 6415 | 6477 | 5000 | |
SwatchColorPicker | mount | 13525 | 13266 | 5000 | |
TagPicker | mount | 3433 | 3424 | 5000 | |
TeachingBubble | mount | 107982 | 107969 | 5000 | |
Text | mount | 1013 | 997 | 5000 | |
TextField | mount | 2100 | 2092 | 5000 | |
ThemeProvider | mount | 1918 | 1898 | 5000 | |
ThemeProvider | virtual-rerender | 1338 | 1340 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2734 | 2745 | 5000 | |
Toggle | mount | 1398 | 1448 | 5000 | |
buttonNative | mount | 668 | 678 | 5000 |
master
branchyarn change
locallyPR flow tips:
Previous Behavior
The DocumentCardPreview assigns an empty string to the alt attribute of the image component.
New Behavior
The DocumentCardPreview assigns the name parameter of the previewImage property to the alt attribute of the image component.
Related Issue(s)
N/A